Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(output): compare python output to rust output #9

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

0xLucqs
Copy link
Collaborator

@0xLucqs 0xLucqs commented Sep 21, 2023

No description provided.

Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

tests/common.rs Show resolved Hide resolved
tests/common.rs Outdated Show resolved Hide resolved
tests/snos.rs Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
tests/common.rs Show resolved Hide resolved
tests/common.rs Outdated Show resolved Hide resolved
@EvolveArt EvolveArt merged commit 8d7b6fb into main Sep 21, 2023
6 checks passed
@EvolveArt EvolveArt deleted the lucas/compare-outputs branch September 21, 2023 21:57
drspacemn pushed a commit that referenced this pull request Sep 27, 2023
* test(output): compare python output to rust output

* test(hints): add test where output is diff

* izldf,sqmdq
maciejka pushed a commit that referenced this pull request Mar 13, 2024
Problem: Cairo structs are accessed in some hints. The Python VM has
abstractions to access fields by name that the Rust VM cannot implement.
This leads to accessing these structs by hardcoding the offset of each
field.

Solution: The new `CairoType` trait allows to read/write an entire
struct in one go. The derive implementation reads/writes fields one by
one according to their place in the struct definition. For cases where
reading/writing the whole struct is not appropriate, the new
`FieldOffsetGetters` macro implements a `get_<field>_offset()` method
for each field of the struct to avoid hardcoding values.
maciejka added a commit that referenced this pull request Mar 20, 2024
* wip

* wip, some progress

* WIP: Declare unimplemented hints

* Fix unused warnings

* Hint: SET_SYSCALL_PTR (#4)

* Add is_n_ge_two hint (#3)

* first iteration of is_n_ge_two hint

* refactor is_n_ge_two hint. remove unused dependencies. start test

* set vm memory in test

* remove unused macros

* fix test and remove debugging prints

* add EOF line

* add test cases

* use rstest cases. refactor hint code to avoid using match. rename hint tests module.

* apply formatter

* add case for n > two

* remove End of file line

* run fmt+nightly command

* run fmt+nightly command

* add hint in hint map and use ids map (#6)

* add hint in hint map and use ids map

* remove unused macro. makes hint constant public

* Add is_on_curve hint and basic test (#1)

* Add is_on_curve hint and basic test

* Improve test

* Add TODO

* Update Cargo.lock

* Attempt at better ids_data

* Set fp and add another segment

* Clean up

* fmt

* Fix clippy lints

* fmt

* fmt

* Add IS_ON_CURVE to hints map

* Use constants for ONE and ZERO

* fmt

* Clean up secp_p comments

* Use vars for var names

* Remove duplicate mod tests

* Add set_ap_to_actual_fee hint (#2)

Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Herman Obst Demaestri <[email protected]>

* Add txn/call hints (#5)

Co-authored-by: Olivier Desenfans <[email protected]>

* Add preimage hints (#8)

Co-authored-by: Olivier Desenfans <[email protected]>

* Feature: read/write Cairo structs safely (#9)

Problem: Cairo structs are accessed in some hints. The Python VM has
abstractions to access fields by name that the Rust VM cannot implement.
This leads to accessing these structs by hardcoding the offset of each
field.

Solution: The new `CairoType` trait allows to read/write an entire
struct in one go. The derive implementation reads/writes fields one by
one according to their place in the struct definition. For cases where
reading/writing the whole struct is not appropriate, the new
`FieldOffsetGetters` macro implements a `get_<field>_offset()` method
for each field of the struct to avoid hardcoding values.

* fix tests

* one more hint

* fix contracts in StarknetOsInput

* few more hints

* ignore block test

* Add a couple missing hints

* calculate tx_hash

* fix TRANSACTIONS_LEN

* Maybe-fix gen_signature_arg hint

* Don't put signature in ap

* remove unnecesary unwraps

* fix post merge problems

* remove outdated tests

* is_reverted hint

* wip

* Pull in relevant hashing code from starknet_on_rust

* Convert equivalent contract structs

* wip

* test with cairo1

* cairo1 test setup, breaks at hint trying to load v1 class

* wip

* wip

* cairo1 class loading + execution without cairo1 hint processor

* fix tests

* fix clippy

* first round of comments

* fix typo

* remove unnecessary code

---------

Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Herman Obst Demaestri <[email protected]>
Co-authored-by: Stephen Shelton <[email protected]>
maciejka added a commit that referenced this pull request Mar 20, 2024
* wip

* wip, some progress

* WIP: Declare unimplemented hints

* Fix unused warnings

* Hint: SET_SYSCALL_PTR (#4)

* Add is_n_ge_two hint (#3)

* first iteration of is_n_ge_two hint

* refactor is_n_ge_two hint. remove unused dependencies. start test

* set vm memory in test

* remove unused macros

* fix test and remove debugging prints

* add EOF line

* add test cases

* use rstest cases. refactor hint code to avoid using match. rename hint tests module.

* apply formatter

* add case for n > two

* remove End of file line

* run fmt+nightly command

* run fmt+nightly command

* add hint in hint map and use ids map (#6)

* add hint in hint map and use ids map

* remove unused macro. makes hint constant public

* Add is_on_curve hint and basic test (#1)

* Add is_on_curve hint and basic test

* Improve test

* Add TODO

* Update Cargo.lock

* Attempt at better ids_data

* Set fp and add another segment

* Clean up

* fmt

* Fix clippy lints

* fmt

* fmt

* Add IS_ON_CURVE to hints map

* Use constants for ONE and ZERO

* fmt

* Clean up secp_p comments

* Use vars for var names

* Remove duplicate mod tests

* Add set_ap_to_actual_fee hint (#2)

Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Herman Obst Demaestri <[email protected]>

* Add txn/call hints (#5)

Co-authored-by: Olivier Desenfans <[email protected]>

* Add preimage hints (#8)

Co-authored-by: Olivier Desenfans <[email protected]>

* Feature: read/write Cairo structs safely (#9)

Problem: Cairo structs are accessed in some hints. The Python VM has
abstractions to access fields by name that the Rust VM cannot implement.
This leads to accessing these structs by hardcoding the offset of each
field.

Solution: The new `CairoType` trait allows to read/write an entire
struct in one go. The derive implementation reads/writes fields one by
one according to their place in the struct definition. For cases where
reading/writing the whole struct is not appropriate, the new
`FieldOffsetGetters` macro implements a `get_<field>_offset()` method
for each field of the struct to avoid hardcoding values.

* fix tests

* one more hint

* fix contracts in StarknetOsInput

* few more hints

* ignore block test

* Add a couple missing hints

* calculate tx_hash

* fix TRANSACTIONS_LEN

* Maybe-fix gen_signature_arg hint

* Don't put signature in ap

* remove unnecesary unwraps

* fix post merge problems

* remove outdated tests

* is_reverted hint

* wip

* Pull in relevant hashing code from starknet_on_rust

* Convert equivalent contract structs

* wip

* test with cairo1

* cairo1 test setup, breaks at hint trying to load v1 class

* wip

* wip

* cairo1 class loading + execution without cairo1 hint processor

* fix tests

* fix clippy

* first round of comments

* wip

* cairo1 syscall handler

* fix imports

* fix fmt, clippy

* fix clippy

* fix fmt

---------

Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Herman Obst Demaestri <[email protected]>
Co-authored-by: Stephen Shelton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants